Skip to content

fixes #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbhishekKumar9984 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fixes #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@
<surefire.redirectTestOutputToFile>true</surefire.redirectTestOutputToFile>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<!-- version properties -->
<cdap.version>6.8.0</cdap.version>
<cdap.version>6.12.0-SNAPSHOT</cdap.version>
<cdap.plugin.version>2.3.4</cdap.plugin.version>
<guava.version>13.0.1</guava.version>
<hadoop.version>2.3.0</hadoop.version>
<guava.version>32.0.0-jre</guava.version>
Comment thread
AbhishekKumar9984 marked this conversation as resolved.
Resolved

@deepika-lalwani123 deepika-lalwani123 Oct 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guava jumps from 13 to 32 with no source changes. Please run the tests against a Guava-32 CDAP to confirm binary compatibility (hydrator-common/format-* were built on Guava 13). Please use Guava >= 32.1.3-jre instead of 32.0.0-jre. 32.0.0 has a known regression (temp dir handling), fixed in 32.0.1. Ideally pin it once in dependencyManagement and add a maven-enforcer requireUpperBoundDeps rule rather than per-dependency <exclusion> blocks.

<hadoop.version>3.3.6</hadoop.version>

@deepika-lalwani123 deepika-lalwani123 Oct 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Hadoop 2.3 -> 3.3.6 bump is unrelated to the Guava upgrade and is a large runtime change. Please move it to a separate PR.

<junit.version>4.11</junit.version>
</properties>

Expand Down Expand Up @@ -187,17 +187,35 @@
<artifactId>hydrator-test</artifactId>
<version>${cdap.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.cdap.cdap</groupId>
<artifactId>cdap-data-pipeline3_2.12</artifactId>
<version>${cdap.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.cdap.plugin</groupId>
<artifactId>hydrator-common</artifactId>
<version>${cdap.plugin.version}</version>
<exclusions>
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
Expand Down
Loading