Repository navigation
Fix IndexOutOfBoundsException in SalesforceWideRecordReader when bulk… - #367
Merged
vikasrathee-cs merged 1 commit intoOct 28, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates SalesforceWideRecordReader to check if the batch iterator has elements before fetching records, initializing the results to an empty list if none exist, and adds a corresponding unit test. Feedback suggests using Collections.emptyList() instead of new ArrayList<>() to avoid unnecessary allocations, simplifying the empty iterator type specification in the test, and replacing the deprecated internal Mockito FieldSetter with standard Java reflection.
vikasrathee-cs
approved these changes
Oct 9, 2026
Sunish-Dahiya
requested changes
Oct 22, 2026
vikasrathee-cs
force-pushed
the
feature/fix-indexOutOfBoundExceptio-during-iteration
branch
from
October 27, 2026 06:26
d8832c5 to
39e1fe0
Compare
Sunish-Dahiya
approved these changes
Oct 27, 2026
… query returns empty results Surface HTTP status and readable error message for non-JSON Salesforce OAuth responses
Ashutosh-Jarvis
force-pushed
the
feature/fix-indexOutOfBoundExceptio-during-iteration
branch
from
October 28, 2026 06:28
4fbdd2b to
291c055
Compare
vikasrathee-cs
merged commit Oct 28, 2026
a17e559
into
data-integrations:develop
11 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check batchIterator.hasNext() before calling fetchBatchRecords() during SalesforceWideRecordReader.initialize() and default results to an empty list when no partitions exist, preventing an IndexOutOfBoundsException when the bulk query returns zero records.