Conversation
Using textContent instead of appending to HTML ensures that escaped HTML characters stay escaped. Fixes issue davatron5000#88
|
While validating this change, I found a regression in the current head: assigning t.innerHTML = '' does not clear the element because t is a jQuery wrapper. A second call then retains the original text and appends the generated spans. Minimal reproduction: jQuery(' Rainbow ').lettering() produces RainbowRainbow on the PR head, while upstream produces Rainbow. In lines mode the sentinel also remains visible. Replacing that assignment with t.empty() clears the target before appending the textContent spans.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using textContent instead of appending to HTML ensures that escaped HTML
characters stay escaped.
Fixes issue #88