Card tags on one line with a +N popover; click a tag to search it - #197
Merged
Merged
Conversation
- Card view: tags are a single row of whole chips. Anything that would wrap is clipped and counted in a "+N" circle at the bottom right; clicking it opens a popover listing every tag (opens upward, closes on outside click/Escape/scroll). - Fix the cause of the squeezed title: the title/dates/header are now non-shrinkable in the fixed-height card, so only the preview gives way and a two-line title is never cut off, whatever the tags do. - Clicking any tag (card, popover, or list view) searches tags:"<name>". That exact form runs as a direct tag filter, so it also works with no AI provider configured (the keyword fallback only searches titles/bodies). Partial tag matches are fine, per the backend's existing substring match. - TagChip gets a clickTitle prop so its tooltip fits the caller. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016UqmgUYdnBJ6ahmmJmWcNc
davior
marked this pull request as ready for review
September 30, 2026 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #196. When a card had a two-line title and tags that wrapped onto two rows, the title got cut off.
Root cause: in the fixed-height card, the title, dates and tags were all shrinkable flex children, so extra tag rows squeezed the title (measured on the old code: the title box was 1.58 lines and clipped).
Changes
+Ncircle at the bottom right. Clicking the circle opens a popover with every tag (opens upward, closes on outside click / Escape / scroll). A single very long tag truncates inside its chip.tags:"<name>", filling the search box and putting it in the URL like any other search.POST /notes/search), rather than going through the AI. This also makes it work with no AI provider configured — the plain-keyword fallback only searches titles and bodies, never tags.#ramanalso findsconfocal-raman.TagChipgets aclickTitleprop so its tooltip ("Search this tag") fits the caller.Interpretation to confirm: the request said to search on "category with the tag name inside quotes". I took that to mean the
tags:search syntax (tags:"name"), since a tag isn't a category. Easy to change if something else was meant.Testing
tsc --noEmitclean;vitest169/169 (newsmartQuery.test.tscovers building/parsing the tag query).🤖 Generated with Claude Code
https://claude.ai/code/session_016UqmgUYdnBJ6ahmmJmWcNc
Generated by Claude Code