New Mac keyring entries don't trust all Python - #2247
Merged
Merged
Conversation
rolandwalker
force-pushed
the
RW/macos-keyring-trust-python
branch
from
September 15, 2026 15:30
c1b3a69 to
510f0aa
Compare
Previously, Mac keyring/keychain entries would trust Python, meaning that any Python app could read the credential. With this change, that only happens if the user follows up with "always allow" to the keychain dialog. This still is not perfect! But apparently the only way to do better on Mac would be to have a mycli shim binary. Based on dbcli/pgcli#1633 .
rolandwalker
force-pushed
the
RW/macos-keyring-trust-python
branch
from
September 15, 2026 15:34
510f0aa to
ce806af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, Mac keyring/keychain entries would trust Python, meaning that any Python app could read the credential. With this change, that only happens if the user follows up with "always allow" to the keychain dialog.
This still is not perfect! But apparently the only way to do better on Mac would be to have a mycli shim binary.
Based on dbcli/pgcli#1633 .
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).