Deprecate /flow-reviewer in favour of /flow-models - #82
Merged
Merged
Conversation
8.4.0 added /flow-reviewer when review was the only selectable role. 8.5.0 generalised the same picker to cover planning and added /flow-models over it, leaving the old command as a pure alias into one open() handler. There is no /flow-planner, so a review-only command implies the reviewer is special when it is not, and hides planning-model routing from anyone who learned it first. Mark the alias in the palette and keep its behaviour unchanged. Removal waits for 9.0.0 per the cadence rule, alongside the reviewer-picker module id. The picker tests now reach review through the role menu, so one alias test is all that has to be deleted then. No version bump: once src/tui.ts diverges from the reviewed commit c0064dc the 8.5.0 feature record can no longer re-verify, and CI runs that verification exactly when a change touches the record or package.json. Correct the picker documentation while here. docs/quickstart.md predated 8.4.0, taught only the opencode.json tuple route and contradicted the README on precedence. docs/troubleshooting.md pinned 8.1.3 through four releases; it now refers to the README, and a contract test keeps the asserted README pins the only ones in maintained prose. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
/flow-reviewershipped in 8.4.0, when review was the only selectable role. 8.5.0 generalised the same picker to cover planning and added/flow-modelsover it, but left the old entry point in place. Both commands now reach oneopen()handler insrc/tui.tswith the same active-work check, staleness check and configuration write — the alias saves one keypress.The surface is also asymmetric. There is no
/flow-planner, so a second review-only command implies the reviewer is special when it is not, and hides planning-model routing from anyone who learned the 8.4.0 command first.What changes
src/tui.tsmarks the alias deprecated in the palette. Behaviour is unchanged.tests/reviewer-picker.test.tsreaches review through/flow-modelsand the role menu, so the suite no longer depends on the alias. One test still exercises the alias directly and asserts its title marks it deprecated — that test and the command block are all 9.0.0 has to delete..agents/plans/10-reviewer-command-deprecation/README.mdrecords the decision.Removal waits for 9.0.0 per the cadence rule in
docs/release-qualification.md, alongside theopencode-plugin-flow.reviewer-pickermodule id. A major needs full qualification for other reasons, so the removal carries no qualification cost of its own.No version bump, deliberately
Once
src/tui.tsdiverges from the reviewed commitc0064dc, the 8.5.0 feature record can no longer re-verify, and.github/workflows/ci.ymlruns that verification exactly when a change touches the record orpackage.json. Neither is touched here.There is also no patch release available to carry this on its own:
assertPatchScoperequires a baseline sharing the candidate's major.minor with a sealed bundle and canary, and only 8.3.0 has those. The CHANGELOG entry is written at the next version bump, since## [Unreleased]is asserted never to appear.Documentation corrected alongside
docs/quickstart.mdis whatREADME.mdsends new users to, and it predated 8.4.0 — it taught only theopencode.jsontuple route, never mentioned either picker, and contradictedREADME.mdon precedence. It now leads with/flow-modelsand states the real order.docs/troubleshooting.mdpinnedopencode-plugin-flow@8.1.3through four releases. It now refers to the README, and a new contract test keeps the asserted README pins the only version pins in maintained prose.Verification
bun run check— 1209 pass, 1 skip, 0 fail. Maintained prose 98,993 of 99,000; src TypeScript 285,152 of 285,696.🤖 Generated with Claude Code