9.0.0: remove the deprecated /flow-reviewer command - #85
Merged
Merged
Conversation
BREAKING CHANGE: `/flow-reviewer` is gone. `/flow-models` reaches the same review picker and also selects the optional planning specialist. The TUI module id changes from `opencode-plugin-flow.reviewer-picker` to `opencode-plugin-flow.model-picker`. 8.6.0 announced the deprecation, satisfying the cadence rule that a surface is announced in one release before a major removes it. The picker tests already reached review through the role menu, so this deletes the one alias test and replaces it with an assertion that a single slash command remains. Also renames the stale 8.4.0 framing that only ever described the reviewer: tests/reviewer-picker.test.ts and FROZEN_PICKER_SOURCE_BYTES. Not for merge until 9.0.0 is authorized and its qualification path is chosen. Merging earlier would put a public-surface removal in a minor release. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vriesd
marked this pull request as ready for review
September 15, 2026 03:59
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
flow.reviewer.selectcommand block fromsrc/tui.ts.opencode-plugin-flow.reviewer-picker→opencode-plugin-flow.model-picker. This is public module identity, which is why it waited for the major.tests/reviewer-picker.test.ts→tests/model-picker.test.ts, andFROZEN_PICKER_SOURCE_BYTES→FROZEN_MODEL_PICKER_SOURCE_BYTES.docs/maintainer-contract.md.Deliberately untouched:
reviewer-picker-v1inevals/qualification/features/8.4.0.json,REVIEWER_PICKER_FILESinscripts/feature-release.ts, and the matching test fixtures. Those are historical records of what 8.4.0 froze and must not be rewritten.Why it is unblocked
8.6.0 shipped the deprecation notice (published 2026-09-15, npm
latest), satisfyingdocs/release-qualification.md:82— announced in one release, removed no earlier than the next major.Worth weighing before merging: 8.6.0 published minutes before this branch was cut. The letter of the rule is met, but nobody has had a realistic window to encounter the notice. If a lifecycle gap matters to you, hold this until 8.6.0 has been out for a while.
No version bump here
Deliberate. Per the 8.6.0 pattern the bump belongs in the reviewed commit of the release PR, so that a release record can name it without a later edit moving a frozen blob. Cutting 9.0.0 also needs a qualification decision — full paid campaign, or a fourth consecutive offline entry, which would be a considerably weaker claim on an exception written for individually reviewed features.
Verification
bun run check— 1214 pass, 1 skip, 0 fail. Removing the command returns budget: maintained prose 98,860 of 99,000 (was 98,924); src TypeScript 284,920 of 285,696 (was 285,152).🤖 Generated with Claude Code