Repository navigation
ci(release): merge the version bump through a pull request - #1689
Merged
Merged
Conversation
main is moving to require a pull request, and the release job pushed the deno.json bump straight to main with GITHUB_TOKEN, which a ruleset can't exempt. Open and squash-merge a bump PR instead, and tag its merge commit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Tagging OptionsShould a new tag be published when this PR is merged?
|
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this Contribution About?
mainis about to require a pull request (repository ruleset, 0 approvals). Thedetermine-tagjob pushes the version bump (Update version to X.Y.Z) straight tomainwithGITHUB_TOKEN, and a ruleset cannot list GitHub Actions as a bypass actor, so that push would be rejected and releases would stop.This lands the bump through a pull request instead, still with
GITHUB_TOKEN:release/X.Y.Z, open a PR tomain, and squash-merge it right away (retries while GitHub computes mergeability);Update version to …when looking for the PR that triggered the push, so a bump PR is never mistaken for the one carrying the tagging reaction.Nothing else changes: the reaction on the "Tagging Options" comment still picks the version, and the release/publish dispatches are the same. PRs opened and merged with
GITHUB_TOKENdon't trigger workflows, so there's no new run and no loop, same as the direct push today. Each release now leaves a mergedUpdate version to X.Y.Z (#N)PR in the history.The
nextprerelease job is untouched (nextis not protected).Rollout
main: require pull requestruleset (same asdeco-cx/admin).Verification
runscript passesbash -n.can_approve_pull_request_reviews: true), and the workflow already hascontents: write+pull-requests: write.main.🤖 Generated with Claude Code
Summary by cubic
mainis about to require pull requests, and the release workflow was pushing the version bump straight tomainwithGITHUB_TOKEN, which a ruleset can't bypass. The bump now lands through a squash-merged PR, and the tag is created on the PR's merge commit instead of the local HEAD.release/X.Y.Z, opens a PR tomain, and squash-merges it with retries while GitHub computes mergeability.Update version to …PRs when finding the PR that triggered the tagging reaction, so the bump PR is never mistaken for it.GITHUB_TOKENdon't trigger workflows, so there's no new run or loop.Update version to X.Y.Z (#N)PR in history.Rollout
main: require pull requestruleset before the next release.Written for commit c702274. Summary will update on new commits.