[opsiff]

Summary by Sourcery

Synchronize rtl8192u association handling and private resource management with the updated kernel driver behavior.

Bug Fixes:

• Preserve rtl8192u association response data in driver-managed state instead of allocating it for each response, avoiding the previous temporary allocation path.

Enhancements:

• Add rtl8192u private network-state allocation and a dedicated private workqueue during driver initialization, with cleanup on probe failure.

[sourcery-ai]

Reviewer's Guide

Synchronizes rtl8192u association handling with the upstream fixes by storing parsed association data in device-private memory instead of allocating it per response, adds corresponding initialization and probe-failure cleanup, and creates the private workqueue used by driver tasks.

Sequence diagram for rtl8192u association response handling

sequenceDiagram
    participant Device as net_device
    participant Softmac as ieee80211_rx_frame_softmac
    participant Priv as r8192_priv
    participant Parser as ieee80211_parse_info_param
    participant Handler as handle_assoc_response

    Device->>Softmac: ieee80211_rx_frame_softmac
    Softmac->>Priv: ieee80211_priv
    Softmac->>Priv: memset(priv->network)
    Softmac->>Parser: ieee80211_parse_info_param
    Parser-->>Priv: parsed association data
    Softmac->>Softmac: memcpy PeerHTCapBuf and PeerHTInfoBuf
    Softmac->>Handler: handle_assoc_response(dev, header, priv->network)

Loading

File-Level Changes

Change	Details	Files
Replace the association-response temporary allocation with per-device persistent network storage.	Add a network pointer to the device-private state. Allocate and zero the network structure during private-state initialization. Reuse and clear the structure while parsing association responses. Pass the persistent structure to HT capability handling and association callbacks. Free the structure on probe failure.	drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c drivers/staging/rtl8192u/r8192U.h drivers/staging/rtl8192u/r8192U_core.c
Introduce a private workqueue during task initialization.	Allocate priv_wq and log allocation failure before work initialization.	drivers/staging/rtl8192u/r8192U_core.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook