Repository navigation
The library can connect a Google Drive source, and only the person who connected it sees the folder browser - #1388
Conversation
Google Drive source: bring upstream deeplethe#1386 and deeplethe#1388 into re-dev
53b1dfa to
e3a4fcf
Compare
WaylandYang
left a comment
WaylandYang
left a comment
There was a problem hiding this comment.
Thanks, this reads well. I'll review it as soon as #1386 is ready. One request now: Disconnect and Reconnect are shown to every editor without a confirmation, and one click drops the connector's folders and replaces their Drive with yours. Please add a confirmation that names whose Drive is connected. I'd also hide or disable Reconnect for anyone who isn't the connector, unless that's deliberate; if it is, say so in the ADR.
e3a4fcf to
006daa0
Compare
|
Thanks, good call! Disconnect now asks first and names whose Drive it is, and says so when it belongs to someone else. Reconnect only shows for the person who connected, and the backend refuses it for anyone else too, so it isn't just hidden. Thank you! |
006daa0 to
801ca69
Compare
WaylandYang
left a comment
WaylandYang
left a comment
There was a problem hiding this comment.
Thanks, the confirmation and connector-only Reconnect look right. Approving; please rebase onto #1386's final commit and we'll merge the two together. (Optional: name the Utopia person who connected in the confirmation, not only the email.)
801ca69 to
899ce0e
Compare
|
Thank you! Rebased onto #1386's final commit as you asked, which dismissed your approval, sorry about that. The confirmation now names the person who connected, not only the email. |
899ce0e to
b0f7fbd
Compare
…r folders a base reads Co-authored-by: muemich <michaelmuellerrw@gmail.com> Signed-off-by: Bogdan Szabo <bogdan@re-cinq.com>
…o connected it sees the folder browser Co-authored-by: muemich <michaelmuellerrw@gmail.com> Signed-off-by: Bogdan Szabo <bogdan@re-cinq.com>
b0f7fbd to
c892156
Compare
The second half of #1222, stacked on #1386. Until #1386 merges this PR also shows its commit, so only the last commit is new here. Part of #1223.
This adds the connect panel to the source settings. Connecting opens Google's consent screen in a popup, and the panel closes it once the source shows as connected. The person who connected then browses My Drive, Shared with me and their shared drives and picks folders. Other editors see which folders are synced and a note that only that person can change them, matching the 403 the backend gives them. Strings are in both en and zh.
pnpm buildandpnpm testpass. Thanks @muemich for the original panel!