Skip to content

perf: keep notification relevance checks as lookups instead of hashes #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnapoli merged 1 commit into from
Oct 27, 2026
+11 −3
Merged

perf: keep notification relevance checks as lookups instead of hashes #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions app/Queries/NotificationBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@
*/
final class NotificationBuilder extends Builder
{
/**
* Each exists is offset by nothing, which keeps it a lookup per notification. Without the offset, exists checks
* joined by "or" get planned as hashes over every follow or every commit, which takes tens of milliseconds for
* someone with thousands of notifications even when only a few are unread.
*/
public function relevant(): self
{
return $this->where(fn (Builder $query): Builder => $query
Expand All @@ -23,16 +28,19 @@ public function relevant(): self
->whereExists(fn (QueryBuilder $follows): QueryBuilder => $follows
->from('follows')
->whereColumn('follows.follower_id', 'notifications.actor_id')
->whereColumn('follows.followed_id', 'notifications.recipient_id')))
->whereColumn('follows.followed_id', 'notifications.recipient_id')
->offset(0)))
->orWhere(fn (Builder $query): Builder => $query
->whereIn('type', [NotificationType::Replied, NotificationType::Quoted, NotificationType::Mentioned, NotificationType::Starred])
->whereHas('commit', fn (CommitBuilder $commit): CommitBuilder => $commit
->where('status', CommitStatus::Approved)))
->where('status', CommitStatus::Approved)
->offset(0)))
->orWhere(fn (Builder $query): Builder => $query
->whereIn('type', [NotificationType::Approved, NotificationType::Rejected])
->whereHas('commit', fn (CommitBuilder $commit): CommitBuilder => $commit
->whereColumn('commits.user_id', 'notifications.recipient_id')
->whereColumn('commits.status', 'notifications.type')))
->whereColumn('commits.status', 'notifications.type')
->offset(0)))
->orWhere('type', NotificationType::LeveledUp))
->withoutSilencedActors();
}
Expand Down
Loading