Repository navigation
fix: keep the commit now and send report buttons the same width while they work - #1229
sulimanbenhalim wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Button width classes resources/js/components/commit-report-button.tsx, resources/js/pages/scheduled-commits/index.tsx |
The report form submit button and “Commit now” button now include the min-w-28 class. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Possibly related PRs
- dev-null-sh/dev-null.sh#1211: Adds minimum widths to buttons with changing request-state labels.
- dev-null-sh/dev-null.sh#1207: Adds a minimum width to a copy button to address label-driven layout shifts.
- dev-null-sh/dev-null.sh#1136: Adds the scheduled-commit flow and its “Commit now” button.
Suggested reviewers: jubianchi
Merge Risk: 
Minimal · up to 96b2a
-
The presentation change is safe to merge.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Summary
Send reportturns into the shorterSending…so the button shrinks by 15px and Cancel slides right next to itCommit nowturns into the longerCommitting…and grows by 2pxChanges
min-w-28on the submit button incommit-report-button.tsxand on the Commit now button inscheduled-commits/index.tsxwhich is the smallest step that fitsSend report(109.3px) andCommitting…(110.4px)Validation
109.3pxto94.5pxfrom 640px up and logged alayout-shifteach time while Commit now went from108.2pxto110.4pxat every sizelayout-shiftVisual evidence
each image is the button's row at rest on top and while its request runs below (report at 1366x650 and Commit now at 1440x900)
Device verification
Independent review
8f887ac4head96b2ae0dafter rounds on each button that suggested bundling them and putting the report class firstLimitations
Summary by CodeRabbit