Skip to content

fix: keep the commit now and send report buttons the same width while they work - #1229

Open
sulimanbenhalim wants to merge 1 commit into
dev-null-sh:productionfrom
sulimanbenhalim:fix/busy-width-followups
Open

sulimanbenhalim wants to merge 1 commit into
dev-null-sh:productionfrom
sulimanbenhalim:fix/busy-width-followups

Conversation

@sulimanbenhalim

@sulimanbenhalim sulimanbenhalim commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • two more buttons change width while their request runs like Vote and Undo did in fix: keep the vote and undo buttons the same width while they work #1211
  • in the report dialog Send report turns into the shorter Sending… so the button shrinks by 15px and Cancel slides right next to it
  • on the scheduled commits page Commit now turns into the longer Committing… and grows by 2px
  • now both keep one width

Changes

  • min-w-28 on the submit button in commit-report-button.tsx and on the Commit now button in scheduled-commits/index.tsx which is the smallest step that fits Send report (109.3px) and Committing… (110.4px)
  • the report class goes first on its button so it adds no conflict for feat: attach images to commit reports #1112 which edits the next line
  • phones stack the report dialog buttons full width so nothing changes there

Validation

  • lint types type coverage JS tests build and the full pest suite pass (4546 tests with 100% coverage)
  • held each request open in headless chrome while signed in and measured both buttons at 1440x900 1366x650 768x1024 640x900 390x844 375x667 and 360x780 in light and dark then failed the request so nothing got reported or submitted
  • before Send report went from 109.3px to 94.5px from 640px up and logged a layout-shift each time while Commit now went from 108.2px to 110.4px at every size
  • after both stay 112px with the same left edge and nothing logs a layout-shift

Visual evidence

each image is the button's row at rest on top and while its request runs below (report at 1366x650 and Commit now at 1440x900)

before after

Device verification

  • desktop chrome at 1440x900 1366x650 768x1024 and 640x900 and chrome emulating 390x844 375x667 and 360x780 phones (no hardware) since this is a button width and not a touch interaction
  • the scheduled row's date still fits on one line next to the wider Commit now down to 360px

Independent review

  • read-only Claude agent: CODE PASS and VISUAL PASS on base 8f887ac4 head 96b2ae0d after rounds on each button that suggested bundling them and putting the report class first

Limitations

  • widths were measured in chrome only

Summary by CodeRabbit

  • Style
    • Set a minimum width for the report form’s submit button and the “Commit now” button, giving them a more consistent appearance.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c55669e9-5f1c-49e1-aece-d9b164ab22eb
Commits

Reviewing files that changed from the base of the PR and between 8f887ac and 96b2ae0.

Files selected for processing: 2
  • resources/js/components/commit-report-button.tsx
  • resources/js/pages/scheduled-commits/index.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The report form submit button and scheduled-commit “Commit now” button now include the min-w-28 class.

Changes: Button Minimum Widths

Layer / File(s) Summary
Button width classes
resources/js/components/commit-report-button.tsx, resources/js/pages/scheduled-commits/index.tsx
The report form submit button and “Commit now” button now include the min-w-28 class.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: jubianchi

Merge Risk: Minimal · up to 96b2a

The presentation change is safe to merge.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surv… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately and clearly describes the main change: keeping the “Commit now” and “Send report” buttons at the same width during requests.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant