Skip to content

Create new indicator progress job for CDIP - #4519

Open
brianbrix wants to merge 21 commits into
developfrom
new-cdip-indicator-import-job
Open

Create new indicator progress job for CDIP#4519
brianbrix wants to merge 21 commits into
developfrom
new-cdip-indicator-import-job

Conversation

@brianbrix

@brianbrix brianbrix commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings October 12, 2026 15:10
Copilot AI reviewed Oct 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved issues were identified that would block approval.

0 open findings

What changed in this PR

Adds a dedicated CDIP NDC indicator progress export job and excludes CDIP indicators from the existing core indicator job.

Changes:

  • Registers the CDIP Quartz job.
  • Implements CDIP indicator aggregation and dashboard export.
  • Prevents duplicate processing by the core job.
File Description
amp/​src/​main/​resources/​xmlpatches/​4.0/​CDIP-AMP-NDC-indicator-dashboard-export-job.xml Updated as part of this pull request.
amp/​src/​main/​java/​org/​digijava/​module/​message/​jobs/​AmpCoreIndicatorFundingJob.java Updated as part of this pull request.
amp/​src/​main/​java/​org/​digijava/​module/​message/​jobs/​AmpCdipIndicatorFundingJob.java Updated as part of this pull request.

🧠 Review effort: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI lite review requested due to automatic review settings October 12, 2026 15:40
Copilot AI reviewed Oct 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved issues were identified that would block approval.

0 open findings

🧠 Review effort: Lite

Copilot AI lite review requested due to automatic review settings October 12, 2026 17:48
Copilot AI reviewed Oct 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The changes require final human review because they are too complex or risky for automated approval.

0 open findings

🧠 Review effort: Lite

Copilot AI lite review requested due to automatic review settings October 12, 2026 18:27
Copilot AI reviewed Oct 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The CDIP query may exclude valid data, and the general job may duplicate CDIP exports.

2 open findings

🧠 Review effort: Lite

Comment thread amp/src/main/java/org/digijava/module/message/jobs/AmpCdipIndicatorFundingJob.java Outdated
Comment thread amp/src/main/java/org/digijava/module/message/jobs/AmpCoreIndicatorFundingJob.java Outdated
Copilot AI lite review requested due to automatic review settings October 12, 2026 18:56
Copilot AI reviewed Oct 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

One or more issues must be addressed before approval.

3 open findings

🧠 Review effort: Lite

Comment thread amp/src/main/java/org/digijava/module/message/jobs/AmpCoreIndicatorFundingJob.java Outdated
Copilot AI lite review requested due to automatic review settings October 12, 2026 19:34
Copilot AI reviewed Oct 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

One or more issues must be addressed before approval.

3 open findings
1 resolved since last review

🧠 Review effort: Lite

Comment thread amp/src/main/java/org/digijava/module/message/jobs/AmpCdipIndicatorFundingJob.java Outdated
Copilot AI lite review requested due to automatic review settings October 13, 2026 03:10
Copilot AI reviewed Oct 13, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

One or more issues must be addressed before approval.

4 open findings

🧠 Review effort: Lite

Comment thread amp/src/main/java/org/digijava/module/message/jobs/AmpCdipIndicatorFundingJob.java Outdated
Copilot AI lite review requested due to automatic review settings October 13, 2026 17:48
Copilot AI lite review requested due to automatic review settings October 14, 2026 03:57
Copilot AI reviewed Oct 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

One or more issues must be addressed before approval.

6 open findings

🧠 Review effort: Lite

Comment thread amp/src/main/java/org/digijava/module/message/jobs/AmpCoreIndicatorFundingJob.java Outdated
@brianbrix
Fix server URL handling in sendReportsInBatches
8f35ede 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings October 14, 2026 11:30
Copilot AI reviewed Oct 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

One or more issues must be addressed before approval.

4 open findings
4 resolved since last review

🧠 Review effort: Lite

Comment thread amp/src/main/resources/xmlpatches/4.0/AMP-Global-Settings-Core-Indicator-Categories.xml Outdated
Comment thread amp/src/main/resources/xmlpatches/4.0/AMP-Unify-Core-Indicator-Export-Job.xml Outdated
Copilot AI lite review requested due to automatic review settings October 14, 2026 11:40
brianbrix and others added 2 commits October 14, 2026 14:41
@brianbrix
Fix schemaLocation path in XML patch
34d218c 
Updated schema location in AMP-Unify-Core-Indicator-Export-Job.xml.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@brianbrix
Update schemaLocation in AMP Global Settings XML
ab87d8c 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI reviewed Oct 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

One or more issues must be addressed before approval.

3 open findings
2 resolved since last review

🧠 Review effort: Lite

Comment thread amp/src/main/resources/xmlpatches/4.0/CDIP-AMP-NDC-indicator-dashboard-export-job.xml
Copilot AI lite review requested due to automatic review settings October 14, 2026 11:44
@brianbrix
Update SQL condition to include multiple job classes
1db1d43 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI reviewed Oct 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

One or more issues must be addressed before approval.

2 open findings
1 resolved since last review

🧠 Review effort: Lite

Copilot AI lite review requested due to automatic review settings October 14, 2026 11:48
Copilot AI reviewed Oct 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Address the moderate logging, transaction-lifetime, and category-ordering issues.

2 open findings

🧠 Review effort: Lite

Copilot AI lite review requested due to automatic review settings October 14, 2026 12:15
Copilot AI reviewed Oct 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

One or more issues must be addressed before approval.

2 open findings

🧠 Review effort: Lite

Copilot AI lite review requested due to automatic review settings October 15, 2026 15:53
Copilot AI reviewed Oct 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

One or more issues must be addressed before approval.

0 open findings

2 resolved since last review

🧠 Review effort: Lite

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brianbrix