Skip to content

chore: promote cli 5.6.0 pinned - #184

Merged
finalerock44 merged 9 commits into
productionfrom
promote/cli-5.6.0-pinned
Sep 18, 2026
Merged

finalerock44 merged 9 commits into
productionfrom
promote/cli-5.6.0-pinned

Conversation

@finalerock44

Copy link
Copy Markdown
Contributor

What & why

Type of change

  • fix — bug fix
  • feat — new feature
  • perf — performance improvement
  • refactor — code change that's neither a fix nor a feature
  • docs — documentation only
  • chore / ci / build / test — tooling, no user-facing change
  • Breaking change (title has ! or PR notes a BREAKING CHANGE:)

Checklist

  • PR title follows the Conventional Commits format (see comment above)
  • pnpm lint passes
  • pnpm typecheck passes
  • pnpm build passes
  • I have not bumped the version or edited CHANGELOG.md (release-please handles this)
  • I have signed the CLA (the bot will prompt on first contribution)
  • Docs / README.md / STYLE_GUIDE.md updated if behaviour or output changed

How to test

finalerock44 and others added 9 commits September 18, 2026 14:48
Only addMedia/runFlow/runScript arguments were bundled, so assertScreenshot
baselines never reached the device. `includedPaths` globs extra files into the
upload; assertScreenshot paths are now also picked up automatically (optional,
so a missing baseline doesn't abort the run).

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: dcd-cli-release-please[bot] <296541543+dcd-cli-release-please[bot]@users.noreply.github.com>
registry-url makes setup-node write `_authToken=${NODE_AUTH_TOKEN}` into
.npmrc. With no token set that resolves to an empty credential, so npm treats
auth as configured, skips the trusted-publishing OIDC exchange and PUTs
unauthenticated — which npm answers with 404. That is why 5.6.0-beta.1 and
beta.2 never published. npmjs.org is the default registry, so nothing else
changes.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
5.6.0-beta.1 and beta.2 were tagged and released but never reached npm:
publish-npm-beta failed with `E404 PUT /@devicecloud.dev%2fdcd` because
setup-node's registry-url wrote an empty auth token, so npm never ran the
OIDC exchange. #179 removed it; nothing releasable has landed since, so this
empty commit forces a cut to prove the fix.

Release-As: 5.6.0-beta.3
Co-authored-by: dcd-cli-release-please[bot] <296541543+dcd-cli-release-please[bot]@users.noreply.github.com>
Betas move from a second release-please track on `dev` to a dispatched
`Release beta` workflow that derives the version from the npm registry, so a
beta can no longer sort below `@latest` the way 5.0.0, 5.2.0 and 5.5.0 did.
The beta config, manifest and npm-publish beta path go with it; CHANGELOG-beta
is frozen at 5.6.0-beta.2.

Stable is unchanged apart from a new back-merge PR after each release, and a
`promotion-pin` CI check: a promotion is a merge, so every beta tag is
reachable from production and release-please picks one as its base unless the
stable version is pinned. That is what left production on 5.6.0-beta.1.

Publishing now happens before the tag and GitHub release are created, so a
failed publish no longer strands a release with no package on npm.
The promotion merge brings dev's beta version across. Leaving it would put a
prerelease on the stable branch until the Release PR lands - and if that PR
stalls, as 5.6.0's did, production sits on a -beta that npm-publish refuses to
publish. release-please rewrites this from the manifest when the release lands.
@finalerock44 finalerock44 self-assigned this Sep 18, 2026
@claude

claude Bot commented Sep 18, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@finalerock44
finalerock44 merged commit b35240e into production Sep 18, 2026
6 checks passed
@finalerock44
finalerock44 deleted the promote/cli-5.6.0-pinned branch September 18, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant