Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3059 +/- ##
==========================================
- Coverage 84.26% 84.25% -0.01%
==========================================
Files 258 258
Lines 56982 57189 +207
Branches 4854 4893 +39
==========================================
+ Hits 48016 48187 +171
- Misses 8139 8171 +32
- Partials 827 831 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweak to substantially improve CPML-like operator compilation times on PRO backends.
Composite subs keys that are all products used to go through SymPy's
subs, i.e. one full traversal per key.MulSubsIndexfiles each key under one of its factors, walks the expression once, and turns sub-multiset matches into a single compounduxreplacerule. Where SymPy could still rewrite a product the multiset test rejects (powers, differing coefficients), or where keys overlap or chain, it falls back toexpr.subs.Previously, every
Mulkey meant a full sympy subs pass over the expression, so the cost was keys × nodes.MulSubsIndexreplaces that with one pass:Mulkey is filed under the base of one of its factors, preferably an Indexed. Its factor multiset is stored with it, e.g.{w[i0]: 1, p[x+3]: 1}.Mulnode, only the keys filed under that node's own factors are candidates. Most nodes have none, so they cost nothing.Counter<=). For example,a*bmatchesa*b*c, leavingc.uxreplacerule,{a*b*c: {a: value, b: None}}, so the result isvalue*c, built without re-evaluation.(a**2*b**2, 1/(a*b))or a different coefficient;Note that this is completely cooked by Claude in its first iteration and will need substantial review and revision before it is ready for merge.