Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3071 +/- ##
==========================================
- Coverage 84.23% 84.23% -0.01%
==========================================
Files 258 258
Lines 57070 57089 +19
Branches 4874 4876 +2
==========================================
+ Hits 48074 48087 +13
- Misses 8169 8173 +4
- Partials 827 829 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_complex_includeswrites the extra complex arithmetic definitions a C++ language needs (def-complex) tocomplex_arith.hin the JIT cache directory, withopen(..., 'w'), on every lowering of an Operator that uses a complex dtype. The directory is shared by every process compiling as the same user, and'w'truncates the file before writing it, so withpytest -n autoone worker can truncate the header while another's compiler is reading it. The compile then fails on the first complex expression, e.g.no match for 'operator*' (operand types are 'int' and 'const std::complex<float>'); in DevitoPRO's CUDA backend the same race shows asuser-defined literal operator not foundfor1.0_if.Changes:
complex_arith_<sha1>.h), written to a private temporary file and renamed into place, and skipped when it already exists. A reader therefore sees either no file or a complete one, and two languages with different definitions no longer overwrite each other.test_complex_arith_headerchecks that two Operators share one header whose content is exactlydef-complex.Verification on main d7f53a3:
language='CXX'Operators from one cache directory: main fails 7 of 960 compiles (twice, 7 each) with the error above; this patch 0 of 960, with a singlecomplex_arith_<sha1>.hin the directory and no leftover temporaries.tests/test_dtypes.py: 47 passed, 5 skipped.🤖 Generated with Claude Code