Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3072 +/- ##
==========================================
- Coverage 84.23% 84.23% -0.01%
==========================================
Files 258 258
Lines 57070 57076 +6
Branches 4874 4874
==========================================
+ Hits 48074 48079 +5
- Misses 8169 8170 +1
Partials 827 827
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_serial_normsintests/test_mpi.pyruns at import time and regeneratesnorms{1,2,3}.npywhenever the stored day differs from today. The ranks spawned by theparallelmarker (mpiexec -n 4 python -m pytest <test>) import the module again, so a session that starts just before 00:00 UTC and reachesTestIsotropicAcousticafter midnight makes all four ranks regenerate the "serial" reference at once, under MPI. Their collectives pair up out of step and whichever rank writes last fixes a garbage reference for the rest of the session.This hit three unrelated PRs on 2026-10-16 (pytest-mpi runs 38979222207, 38979245108, 38979251087):
test_adjoint_F[(4, *)-1]failed five times each withnorm(u) = 1577.6036(correct) againstEuof 9.0e153, 1563.19 and 4.9e108, identical within a job. Every passing job that night had its session start and its adjoint tests on the same UTC date.Changes:
DEVITO_PYTEST_FLAGenvironment variable thatconftest.pyalready sets for them is the marker (MPI is not initialised yet at import time, soCOMM_WORLDcannot be used there).Verification on main d7f53a3 plus this patch:
DEVITO_PYTEST_FLAG=1 DEVITO_MPI=basic mpiexec -n 4 ...) against a norms file backdated by one day: on main all four ranks regenerate it; with this patch the file is untouched andtest_adjoint_F[(4, basic)-1]passes, three runs each.pytest -n 8 tests/test_mpi.py -k test_adjoint_codegenfrom a clean directory, eight workers regenerating at once: 2 passed, three complete norms files, no leftover temporaries.pytest tests/test_mpi.py -k TestIsotropicAcousticthrough theparallelmarker: 19 passed in 11 min.🤖 Generated with Claude Code