Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3073 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 258 258
Lines 57070 57071 +1
Branches 4874 4874
=======================================
+ Hits 48074 48075 +1
Misses 8169 8169
Partials 827 827
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Creating |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
parallelmarker launches each MPI test asmpiexec --oversubscribe --timeout 300 .... The cap is there to stop a hung test blocking CI, but it is hard-coded, and on the DevitoPRO CI runners (pytest -n auto, eight workers withOMP_NUM_THREADS=4on one cpuset) the heaviest four-rank tests already run that long:test_abox.py::TestIsotropicAcoustic::test_backward_mpi[4]took 271 s in a passing job and 302 s in the next one, which mpiexec aborted (devitopro run 38969858835, main). Both versions of the test spend their time waiting for CPU, not computing; the serial variant takes 6 to 8 s.Changes:
DEVITO_MPI_TEST_TIMEOUT, defaulting to 600 s. A hang is still caught within ten minutes; a slow runner can raise it without touching the code.Verification on main d7f53a3:
DEVITO_MPI_TEST_TIMEOUT=3 pytest "tests/test_mpi.py::TestDistributor::test_partitioning": both ranks reportTimeout: 3 secondsand the test fails, as intended.Why the tests are slow in the first place: the ranks and the OpenMP threads of every worker spin-wait while oversubscribed. Reproduced on DevitoPRO main with
tests/test_abox.pyandtests/test_fft.py -k "TestIsotropicAcoustic or stream_out", eight xdist workers withOMP_NUM_THREADS=4pinned to 16 CPUs (a shared, loaded host, so relative numbers only):OMP_WAIT_POLICY=passiveOMPI_MCA_mpi_yield_when_idle=1test_fft_stream_outmedianThe DevitoPRO CI environment change is a separate PR there; this one keeps a hang from waiting longer than ten minutes while giving legitimately slow runners room.
🤖 Generated with Claude Code