Repository navigation
Conversation
Windows CI now runs the tests that exercise Windows-specific behaviour, selected by scripts/platform-tests.js; the generic suite runs on ubuntu under Node 20 and 22.
Tests that reach a platform branch through any production require, or that drive real processes and filesystem identity, keep running on Windows; a missing isolated file and a matrix OS matched by no test step now fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second slice of #1026. The Windows cell now runs only the tests that exercise Windows-specific behaviour. The generic suite keeps running on ubuntu under Node 20 and 22.
scripts/platform-tests.js(rule C) selects a test when it, or any production module it reaches through relative requires, has a platform marker. Markers coverprocess.platform, Windows paths, ConPTY, links, real processes and filesystem identity. A test can also opt in explicitly with// platform: windows.scripts/run-tests.js --platform-onlyfails closed:ISOLATED_FILESentry fails.test.yml:Follow-up, not in this PR:
cli-session-state.jspulls in about 43 tests that cannot exercise its platform branch, throughbg-worker-liveness.js→procStartMatches. Splitting that pure helper out would cut them.