Skip to content

(deps): port upstream js-yaml and postinstall security fixes - #846

Merged
devsuitup merged 4 commits into
mainfrom
wt/817
Oct 28, 2026
Merged

devsuitup merged 4 commits into
mainfrom
wt/817

Conversation

@devsuitup

Copy link
Copy Markdown
Owner

Closes #817. Ports two upstream security fixes by Anupam Mediratta.

  • doctly/switchboard#101: js-yaml 4.1.1 → 4.3.2 (GHSA-5p4m-2wfm-xmqj). electron-updater parses latest.yml with it. The lock was regenerated with npm update js-yaml --package-lock-only (npm 10); parsed, the only package whose entry changes is node_modules/js-yaml, the rest of the diff is key order.
  • doctly/switchboard#87: scripts/postinstall.js passes native file names to codesign as literal execFileSync arguments instead of a shell string. The environment scrub and the install steps now run only when the script is executed directly, so requiring it in a test does nothing. The helper test also runs on every build platform before dependency installation.

test/postinstall.test.js covers names with spaces, quotes, backslashes and $(), import isolation, Windows behaviour and the install fallback; reverting to the template string makes it fail. No user-visible change, hence no-changelog.

Harness-Claim: true
Agent: switchboard-dev
Host: ANCHOR
Base-Ref: origin/main
Base-SHA: 7f1dc83
Claimed-At: 2026-10-28T10:33:24.0922703Z
Nonce: 8450c114d08159f3
js-yaml 4.3.2 fixes GHSA-5p4m-2wfm-xmqj; postinstall no longer builds a
shell command from native file names.
@devsuitup devsuitup added the no-changelog The PR changes nothing a user sees; the CHANGELOG.md check is waived label Oct 28, 2026
@devsuitup
devsuitup merged commit 24f092b into main Oct 28, 2026
12 checks passed
@devsuitup
devsuitup deleted the wt/817 branch October 28, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog The PR changes nothing a user sees; the CHANGELOG.md check is waived

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(deps): port upstream js-yaml and postinstall security fixes

1 participant