Repository navigation
docs(helm): retry recovery log capture and explain refusals - #6468
Merged
Merged
Conversation
Signed-off-by: Guillaume Loret <guillaume@openworklabs.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
There was a problem hiding this comment.
Warden clearance. Complete security and confidentiality review of 8b6f7cad5f789a3ec4241588805414bac832080e found no high or medium security findings and no confidentiality findings. Any new push dismisses this approval. Analysis run
Contributor
Warden: approvedNo high or medium security findings and no confidentiality findings. Reviewed |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the Helm Admin-team recovery guide to find the release with
helm list, capture the migration Job with an explicit retry loop instead of relying on kubectl's native startup retry, and explain thatUPGRADE FAILEDis expected when the recovery guard refuses a run. The guide also shows how to read the retained failed Job log.This is documentation only. It does not change recovery SQL, application permissions, images, workflows or Helm hook cleanup. The loop cannot retrieve a Job already deleted after success, so capture must start during the upgrade; the text also warns against reading a previous failed Job when retrying. Existing multi-organization transaction caveats remain unchanged.
Context
Clients differ in how they handle a container that has not started. An explicit shell retry makes the documented capture independent of that native retry behavior. A refusal blocks the pre-upgrade hook, but does not replace the existing Den workloads; the guide now distinguishes that expected failure from a successful upgrade.
Verification
git diff --check: passed.bash -nafter substituting the documented placeholders.