Repository navigation
feat(workbot): add Cmd+K command palette behind a flag - #6471
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
OpenWork evidence
Run details · Open the preview to inspect evidence and sandbox options. |
Member
Author
|
Screenshots from the headless proof run (real Workbot page, 1280×800 and 390×844).
|
![diff-warden[bot]](https://avatars.githubusercontent.com/u/118544361?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Warden clearance. Complete security and confidentiality review of 6d51d42df579eec9724576aee58f58f7f6d1d1f6 found no high or medium security findings and no confidentiality findings. Any new push dismisses this approval. Analysis run
Contributor
Warden: approvedNo high or medium security findings and no confidentiality findings. Reviewed |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Workbot gets a Cmd+K / Ctrl+K command palette, plus a search button in the header, behind a new feature flag.
What problem does it solve?
Moving between chats, pages, background tasks and settings in Workbot takes several clicks and the mouse. People who live in the keyboard have no fast way around.
What was the situation before?
No palette and no shortcut: chats sit in a drawer, pages in the header, tasks only in the conversation.
How is this implemented?
workbotCommandPalette(cloud and self-hosted, off) inpackages/features/src/registry.ts. Den sendscommandPaletteon/v1/workbot/session→ Workbot/v1/workbot/me→WorkbotHost.commandPalette. When it's off, there's no button, the shortcut does nothing, and no requests go out. Safe to turn off at any time.ee/packages/workbot-ui/src/command-palette.tsx: Base UI Dialog + inline Autocomplete. Every row is an action Workbot already has: switch or start a chat, stop a reply or task, open a page, files, or a Den page. Nested lists open with Tab, Cmd/Ctrl+Enter runs a row's second action, and recently used rows come first.command-palette-search.ts: fuzzysort ranking and match highlighting, the same approach as the desktop palette.docs/features/workbot-command-palette/README.md.What else changed?
fuzzysortadded to@openwork-ee/workbot-ui(already used by the desktop app).pnpm --filter @openwork-ee/workbot test:command-palette.Release note
none
Evidence
evals/proofs/workbot-command-palette.proof.test.ts: before, the feature is off, there's no button, and Cmd+K does nothing. After, Cmd+K from the message box opens the palette, search highlights matches, Tab opens the Chats list, no-match text shows, Cmd+Enter stops a task, Enter opens Calendar, Esc puts focus back, and it fits a 390px phone.Design: P1, P4, P5, P6, S6, S7, C1, C6, C7, V2, V5, V6