Skip to content

fix(celld): configure desktop snapshot outside runner secret - #6477

Merged
benjaminshafii merged 1 commit into
devfrom
fix/celld-snapshot-variable
Oct 25, 2026
Merged

benjaminshafii merged 1 commit into
devfrom
fix/celld-snapshot-variable

Conversation

@benjaminshafii

Copy link
Copy Markdown
Member

Summary

  • Allow the optional HEADLESS_COMPUTER_SNAPSHOT variable in the celld-production environment to override the snapshot slug in CELLD_RUNNER_VARS.
  • Use the same override for the pre-deploy compatibility check and the runner bundle; when unset, the current JSON-secret value remains the fallback.
  • Document the setting in the Workbot and celld runner operations guides.

Evidence

Build verification

  • actionlint .github/workflows/celld-runner-deploy.yml — passed.
  • Snapshot override/fallback smoke test using jq — passed for both unset and set variable cases.
  • git diff --check — passed.

API verification

No API changes.

UI verification

No UI changes; screenshots not applicable.

Test instructions

  1. In GitHub Settings → Environments → celld-production, set the plain variable HEADLESS_COMPUTER_SNAPSHOT to the current Freestyle snapshot slug.
  2. Run or rerun “Deploy runner to celld”.
  3. Confirm the snapshot check accepts that slug and the runner bundle contains it. Unset the variable to verify the CELLD_RUNNER_VARS value remains the fallback.

@vercel

vercel Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
openwork-app Ready Ready Preview Oct 25, 2026 1:07am UTC
openwork-den Ready Ready Preview Oct 25, 2026 1:07am UTC
openwork-diagnostics Ready Ready Preview Oct 25, 2026 1:07am UTC
openwork-landing Ready Ready Preview, v0 Oct 25, 2026 1:07am UTC

Request Review

@benjaminshafii

Copy link
Copy Markdown
Member Author

Verification

  • actionlint .github/workflows/celld-runner-deploy.yml — passed.
  • git diff --check — passed.
  • A local jq smoke test confirmed both paths: a set environment variable overrides the JSON secret for the check and bundle; an unset variable retains the JSON-secret value.
  • No API or UI changes; no screenshots applicable.

The production workflow was not dispatched: this PR only adds support for the optional override, and the production environment setting should be changed after merge/approval.

@benjaminshafii
benjaminshafii deployed to pr-internal-specs October 25, 2026 01:06 — with GitHub Actions Active
@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

OpenWork evidence

Status Commit Preview Updated
🟢 Ready · evidence passed 22881af Open preview 2026-10-25 01:14:04 UTC

Run details · Open the preview to inspect evidence and sandbox options.

@diff-warden diff-warden Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warden clearance. Complete security and confidentiality review of 22881afd08528b32f94f35a8baa55300437c249c found no high or medium security findings and no confidentiality findings. Any new push dismisses this approval. Analysis run

@diff-warden

diff-warden Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Warden: approved

No high or medium security findings and no confidentiality findings.

Reviewed 22881afd0852 · Warden run · Updates after every Warden run.

This branch was successfully deployed

6 active deployments
Evidence / PR 6477 — 22881afd Deployed Oct 25, 2026 by github-actions[bot]
Preview – openwork-landing — 22881afd Deployed Oct 25, 2026 by vercel[bot]
Preview – openwork-app — 22881afd Deployed Oct 25, 2026 by vercel[bot]
Preview – openwork-den — 22881afd Deployed Oct 25, 2026 by vercel[bot]
Preview – openwork-diagnostics — 22881afd Deployed Oct 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant