Skip to content

feat(app): allow model selection on automation proposals - #6478

Draft
ali-ulu wants to merge 2 commits into
different-ai:devfrom
ali-ulu:feat/automation-proposal-model-picker
Draft

ali-ulu wants to merge 2 commits into
different-ai:devfrom
ali-ulu:feat/automation-proposal-model-picker

Conversation

@ali-ulu

@ali-ulu ali-ulu commented Oct 25, 2026

Copy link
Copy Markdown

Summary

  • Add a model picker to the automation.propose review card using OpenWork's existing AutomationModelButton and ModelPickerModal.
  • Preserve the member/runtime-available model catalog, reasoning variant selection, and the existing explicit Create Automation confirmation.
  • Submit the selected providerId, modelId, and variant through the existing Desktop or Cloud create API. An unavailable proposed model is never silently replaced; the person can select an available alternative in the card.
  • Add a regression test for explicitly selecting an available model when the proposal's model is unavailable.

Validation

  • bun test tests/automation-proposal-model.test.ts — 4 passed.
  • git diff --check — passed.
  • pnpm --filter @openwork/app typecheck is currently blocked by an existing upstream error at apps/app/src/react-app/domains/cloud/auto-access-ui.tsx:196 (TS18004: workspaceId is referenced but is not in scope). That file is unchanged in this branch and the error exists at base fcb6464.

This is a draft for review; it is not merged.

@vercel

vercel Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
openwork-den Skipped Skipped Oct 25, 2026 8:55pm UTC
openwork-diagnostics Skipped Skipped Oct 25, 2026 8:55pm UTC
openwork-landing Skipped Skipped Oct 25, 2026 8:55pm UTC

Request Review

@vercel
vercel Bot temporarily deployed to Preview – openwork-diagnostics October 25, 2026 02:56 Inactive
@vercel
vercel Bot temporarily deployed to Preview – openwork-landing October 25, 2026 02:56 Inactive
@vercel
vercel Bot temporarily deployed to Preview – openwork-den October 25, 2026 02:56 Inactive
@vercel

vercel Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

@ali-ulu is attempting to deploy a commit to the Different AI Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Contributor screen: passed

Commit f2e34ddb40 · run

No hidden characters, dependency, database or obfuscation concerns.

Nothing else runs yet. A maintainer reviews the changes then comments /test to start the AI screen, the tests and the Warden security review.

@vercel
vercel Bot temporarily deployed to Preview – openwork-diagnostics October 25, 2026 20:55 Inactive
@vercel
vercel Bot temporarily deployed to Preview – openwork-den October 25, 2026 20:55 Inactive
@vercel
vercel Bot temporarily deployed to Preview – openwork-landing October 25, 2026 20:55 Inactive

ali-ulu commented Oct 25, 2026

Copy link
Copy Markdown
Author

Follow-up: fixed the no-model-proposed edge case in f2e34ddb40e131a470581b713ff6c533814853d6. The proposal now passes undefined to resolveProposalModel when no model was proposed, so Cloud and restricted Desktop placements can resolve to a model the member can actually run. The updated contributor screen passed. Maintainer review is still needed to authorize the gated test/Warden run for this exact head (/test f2e34ddb40e131a470581b713ff6c533814853d6). The Vercel app deployment also still requires Different AI team authorization.

This branch was previously deployed

3 inactive deployments
Preview – openwork-diagnostics — f2e34ddb Deployed Oct 25, 2026 by vercel[bot]
Preview – openwork-den — f2e34ddb Deployed Oct 25, 2026 by vercel[bot]
Preview – openwork-landing — f2e34ddb Deployed Oct 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant