Repository navigation
fix(server): enable WAL mode and busy timeout on runtime sqlite database - #6481
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 4 Skipped Deployments
|
Contributor
![diff-warden[bot]](https://avatars.githubusercontent.com/u/118544361?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Warden clearance. Complete security and confidentiality review of e1dbbd849a26a77d6a6c840c60001128bfee42ea found no high or medium security findings and no confidentiality findings. Any new push dismisses this approval. Analysis run
Contributor
Warden: approvedNo high or medium security findings and no confidentiality findings. Reviewed |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Fixing "database is locked" errors in OpenWork's local runtime database.
What problem does it solve?
Several parts of the app can use the same database file at once, and they sometimes block each other. When that happens, reads fail with "database is locked" (Sentry DESKTOP-APP-4N).
What was the situation before?
Multiple modules each keep their own connection to the same
runtime.sqlitefile. The database used SQLite's default rollback journal mode. While one connection was writing, it held an exclusive lock that also blocked other connections from reading.How is this implemented?
openRuntimeSqliteDatabase()now setsPRAGMA journal_mode=WALright after opening the database, so readers and writers can work at the same time. This applies to both the Bun and Node:sqlite paths.PRAGMA busy_timeout=5000on both paths, so a briefly locked database is retried for up to 5 seconds instead of failing immediately.What else changed?
none
Release note
Fixed intermittent "database is locked" errors when OpenWork reads and writes its local runtime data.
Evidence
pnpm typecheck: passes with zero errors.node --test apps/server/test/node-runtime.test.mjs: 25/25 tests pass.Fixes DESKTOP-APP-4N
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry at no cost. You can adjust this setting at any time.