Repository navigation
Conversation
Langfuse 4.31.0 removed the unstable evaluator API that genki read its judges through, and read() turned its 404 into "no rules": on 4.72.0 Byggeklosser showed no judges and a ticked run went out unchecked. Judges are now read through /api/public/v2/evaluation-rules and /api/public/v2/evaluators, every page. A judge is an enabled rule with one active LLM-as-a-judge evaluator and the isExperimentItemRootSpan filter; any other enabled rule with an active evaluator is unreadable, and a paused evaluator neither lists nor counts, but refuses a run that uses it with Langfuse's message. A listing that cannot be read refuses the run, says so in the start dialog (judges-unreadable) and shows as one refused block in Byggeklosser. Labels follow the score name, which 4.72.0 takes from the evaluator: scores record it as details.scoreName, and rules that share an evaluator get no labels, named in the fetch result and the console. ADR 0040 is amended, with the 4.4.0 to 4.72.0 upgrade measured.
A rule with several evaluators is refused before a paused one is taken for the whole rule, and a rule whose evaluator is not listed counts as unreadable, since Langfuse still runs both. Rules that share a name are refused, and shared score names are found by name, which Langfuse keeps unique for neither rules nor evaluators. A paused judge is not counted as unread cost. The unreadable block shows no field or model, the console's shared-name notice is a warning, and the live deletion test waits for Langfuse's two-minute deletion cycle. ADR 0040 says what the upgrade from 4.4.0 does as Langfuse's backfill does it: rules that agree on template, mapping and score name share one evaluator.
Langfuse runs nothing for such a rule, so it is neither listed nor counted, where it was refused as having several evaluators and stopped every sent run. The portal's same-name refusal has a test, and ADR 0040 names pause state among what the upgrade groups evaluators by.
Contributor
Author
|
Ready for review. Blind review, a claim-checking review and a check of the fixes are done and CI passes. Open:
|
5 of 6 tasks
This was referenced Nov 2, 2026
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #220.
What and why
Langfuse 4.31.0 removed the
unstableevaluator API genki reads its judges through, and genki read the 404 as "no rules". On 4.72.0 Byggeklosser showed no judges, and a ticked run went out to a project whose rules would judge and bill it. Closes #221.packages/providers-langfuse/src/judges.tsreads/api/public/v2/evaluation-rulesand/api/public/v2/evaluators, every page by cursor, and by id for "Dommeren er endret". A judge is an enabled rule with one active LLM-as-a-judge evaluator and the filterisExperimentItemRootSpan = true. Any other enabled rule with an active evaluator, or with an evaluator the listing lacks, is a rule genki cannot read. A rule with more than one evaluator is refused, and so are rules that share a name, which Langfuse allows. A paused evaluator is neither listed nor counted, but it refuses a run that uses it with Langfuse'spausedMessage.judges-unreadableinGET …/eval-runs/sending), and Byggeklosser shows one refused block per connection (sink-judges:<connection>). 4.4.0 has no v2 API, so it ends up here.details.scoreName; older scores match the rule name. When two rules write scores under one name, neither gets labels:POST /operator/quality/sink-labels/fetchanswersshared, and the console warns why. The 35-character text is gone from the labels help.Not in this PR: reading dataset, environment and name filters; the judge set (#218).
How it was tested
npm run checkpasses after merging main, which fixed the month-name tests.New tests, each seen red first:
The fakes in
judges.test.tsandquality.test.tsnow answer the v2 routes, with shapes measured on a local 4.72.0.Live tests ran with
LANGFUSE_LOCAL_URLagainst a local 4.72.0: "lists an item-root rule of a live Langfuse 4.72.0 as a judge, and counts a rule without the filter as unreadable", the connection check, and a traced run that lands as an experiment and is purged. The judge-trace deletion test now waits up to 4 minutes. Langfuse's worker deletes on a cycle of about 2 minutes, and the old 60 s wait failed in about half the runs.npm run checkpassesChecklist
packages/providers-*docs/architecture/modulesare updated if a contract, boundary or module changed