Skip to content

waitForSync reports synced when the only peer has disconnected #86

Open

Description

@gmaclennan

Part of #80.

$sync.waitForSync('full') only checks connected peers, so if the only peer drops part way through it resolves as "synced" with nothing left to check. Anything that relies on that promise (the cloud's tests, scripts, server-side callers) believes sync completed when, for example, 24 of 100 observations arrived. The mobile Exchange screen derives its stage from the peer count, so users do not see this directly, but it hides interrupted syncs from the code that could react to them.

Fix:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions