Repository navigation
refactor(discord_bot): conform /pm calendar view to UI standards (fixes #115) - #116
Merged
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #115.
Conforms the
/pm calendarephemeral view (CalendarFeedView) to project UI/UX standards, timeout lifecycle, and session management contracts.Changes
Closebutton (style=discord.ButtonStyle.secondary,row=0) and callback toCalendarFeedViewthat cleans up and unregisters fromMenuSessionManager.MenuSessionManager.register_menu(interaction)during/pm calendar. AddedMenuSessionManager.update_interaction(...)to maintain active session state across message edits.CalendarFeedView._on_regenerate_clickedto updateself._initial_interactionand synchronize withMenuSessionManagersoBaseView.on_timeoutoperates against a live interaction token rather than an expired one.PmCog.calendartoDiscordViewRouter.build_calendar_feed_view(...).test_calendar_feed.py,test_hub_menu_dismissal.py, andtest_menu_manager.py. Synced requirement changes toopenspec/specs/hub-menu-dismissal/spec.md.Acceptance Criteria
CalendarFeedViewincludes a secondaryClosebutton in row 0.Closedeletes the ephemeral message and stops the view.MenuSessionManager.register_menu().on_timeout()dismisses the message and unregisters the session.