You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I like the idea behind this PR; our current normalize example is weak because it shows very little of DimWit. However, while it's an improvement, I don't like the new example. First, it doesn't make sense to me: A single layer with a tanh activation and minimizing the MSE; doesn't the model then just learn to predict 0? Where is this model from? The model also adds explicit Params, which could confuse deep learning folks. We also have a similar example (minimal MLP) in deepwit: https://github.com/dimwit-dev/deepwit
Minor: x.vmap(Axis[Batch])(layer(p)).pow(Tensor0(2.0f)).meancan be simplified to ` x.vmap(Axis[Batch])(layer(p)).pow(2.0).mean?
I will try to come up with an example I like more in the next few days to have a counterproposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example in the README file is not great. This is an attempt to create an example that better illustrates what dimwit can do.