Repository navigation
Prospecting defaults to 3 contacts per company - #39
Merged
Merged
Conversation
The API now fills in 3 contacts per company when a brief gives no count, instead of 1. The SDK model default, the CLI help and the docs still promised 1, so a caller reading them would plan around the wrong number of people per company.
| brief=implicit.brief, target_companies=25, contacts_per_company=2, max_actions=0, max_candidates=0 | ||
| ) | ||
| assert (implicit.target_companies, implicit.contacts_per_company) == (1000, 1) | ||
| assert (implicit.target_companies, implicit.contacts_per_company) == (1000, 3) |
There was a problem hiding this comment.
Explicit default lacks coverage The updated test checks that an omitted count stays off the wire, but its explicit case uses
2. It does not protect the new default of 3 when a caller supplies it explicitly. That value must be sent so it can override a different count inferred from the brief; otherwise a future serialization change could break that behavior unnoticed.
Suggested change
| assert (implicit.target_companies, implicit.contacts_per_company) == (1000, 3) | |
| assert (implicit.target_companies, implicit.contacts_per_company) == (1000, 3) | |
| assert ProspectingBrief(brief=implicit.brief, contacts_per_company=3).to_wire() == { | |
| "brief": implicit.brief, | |
| "contacts_per_company": 3, | |
| } |
Knowledge Base Used: Quality and delivery automation
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/discolike/tests/test_prospecting.py
Line: 420
Comment:
**Explicit default lacks coverage** The updated test checks that an omitted count stays off the wire, but its explicit case uses `2`. It does not protect the new default of `3` when a caller supplies it explicitly. That value must be sent so it can override a different count inferred from the brief; otherwise a future serialization change could break that behavior unnoticed.
```suggestion
assert (implicit.target_companies, implicit.contacts_per_company) == (1000, 3)
assert ProspectingBrief(brief=implicit.brief, contacts_per_company=3).to_wire() == {
"brief": implicit.brief,
"contacts_per_company": 3,
}
```
**Knowledge Base Used:** [Quality and delivery automation](https://app.greptile.com/discolike/-/custom-context/knowledge-base/discolike/discolike-python/-/docs/quality-and-delivery.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API now uses 3 contacts per company when a brief doesn't state a count (was 1). The SDK's
ProspectingBriefdefault, CLI help, READMEs and CHANGELOG still said 1.requests.pyis regenerated from the spec; the field stays optional and 1-10, and is still omitted from the wire when unset, so older and newer SDKs behave the same against any server.Pilot checkpoint reply copy also changed server-side. No change needed here: the CLI shows and sends the
suggested_repliesthe server returns, and hardcodes none.The PR appears safe to merge; the remaining issue is a non-blocking test-coverage gap for an explicit value of 3.
Fix with agent prompt
Summary
The PR aligns the SDK model default, CLI help, documentation, and an SDK test with the API’s stated fallback of three contacts per company. An unset count remains omitted from the request body, leaving brief inference to the server.
Reviews (1) · Last reviewed commit: "Prospecting defaults to 3 contacts per c..."