Repository navigation
Admin: Resolve route claims only from the components that claim (#685) - #700
Merged
Merged
Conversation
- Keep the claiming handles apart in UiRegistry - Register claimRoute() only for the schemas of views and forms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UiRegistry, so mounting fields doesn't change the claimsclaimRoute()only for the schemas of views and formsOpening a section with 50 inlined items resolves the claims 2 times instead of 53. The benchmark of #654 (30 × 12 inlined rows) shows no measurable difference (682–746 ms vs 678–713 ms), but the work no longer grows with the number of schemas times the number of claimants.
Closes #685