Repository navigation
fix(setup): align row controls and switch thumbs - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rows without a “more” menu reserved an invisible menu button plus its flex gap, leaving an extra 34–38px after their final control. This showed up beside Overview’s “How to fix”, T3 Connect’s “Set up”, and the Instructions selectors, with the same issue in other console lists.
Remove the placeholder and its responsive CSS everywhere it was used. The last real button, select, switch target, or channel control now ends at the standard 16px row inset. The existing menu controls and phone wrapping continue to work. Refresh the README and Ports guide screenshots to match.
The enabled switch thumb also travelled 2px too far, reaching the track’s right edge. Correct its travel in the shared component so both switch sizes keep the same 2px inset above, below, and at their resting end in either state. Document the correction beside the other vendored component fixes.
The geometry audits now check both the final row control against its right inset and the rendered switch thumb’s clearances. They reproduce the original defects and pass afterward.
Validation:
Updated console screenshots