Repository navigation
Conversation
Generated-with: gpt-6.1-sol (Codex)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web renderer inserts a fenced code block's language string directly into a quoted HTML class attribute. A quote followed by an img tag breaks out of that attribute and becomes additional markup in the preview. Escape this string with the existing HTML-escaping function before interpolation.
Add six Node built-in renderer tests that execute the shipped render functions without evaluating their HTML. Four malicious/attribute-special-character cases fail on exact base 0aea162 and pass after the fix. Ordinary language/body escaping and Unicode remain covered. Run these tests explicitly with Node22 in the existing eight native Windows/Linux CI cells.
Validation: 6 renderer cases and 9 existing web-companion tests pass locally; workflow YAML parses; git diff --check passes. Native CI and independent review remain pending. No version, dependencies of the application, release, service-worker cache or runtime mirror change.
Related to CodeQL alert3's preview HTML sink. This fixes the reproduced code-fence attribute injection only; it does not establish complete sanitizer safety or resolve every alert flow. Do not dismiss the alert on this evidence alone. No browser exploit was executed.
Author model: gpt-6.1-sol (Codex). Draft only; merges disabled. Independent model review pending.