Repository navigation
Match st_emblem.cpp - #140
Open
loserkidsblink wants to merge 1 commit into
Open
loserkidsblink wants to merge 1 commit into
loserkidsblink wants to merge 1 commit into
Conversation
Report for RSBE01_02 (7074404 - 52d0522)📈 Matched code: 1.77% (+0.04%, +6500 bytes) ✅ 5 new matches
|
loserkidsblink
changed the title
loserkidsblink
force-pushed
the
decomp/castle-siege-controller
branch
from
October 10, 2026 18:55
41317d4 to
e4619a9
Compare
loserkidsblink
changed the title
loserkidsblink
changed the title
loserkidsblink
force-pushed
the
decomp/castle-siege-controller
branch
from
November 8, 2026 01:36
e4619a9 to
b490919
Compare
loserkidsblink
force-pushed
the
decomp/castle-siege-controller
branch
3 times, most recently
from
November 8, 2026 10:48
15eb6e3 to
f36ccc5
Compare
loserkidsblink
changed the title
…nd createObj Stage::stageParamChange takes the scene number (int) and returns bool, per its asm (li r3,1 / li r3,0; r4 is left untouched and forwarded to the virtual call through this+0xA4). The BrawlHeaders-sourced mangled name stageParamChange__5StageF had no parameter code, which no MWCC version can emit; header, symbols.txt and RSBE01.lst are fixed together. Passing m_scene_num is what puts the loop bound in r4 and completes updateScene. st_emblem.rel now links byte-identical; create__8stEmblemFv is kept via force_active like st_crayon.
loserkidsblink
force-pushed
the
decomp/castle-siege-controller
branch
from
November 8, 2026 12:51
f36ccc5 to
52d0522
Compare
loserkidsblink
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the gmMeleeInitData header change from #161 since createObj uses it.
Header changes that affect BrawlHeaders users:
Stage::stageParamChangeisbool stageParamChange(int sceneNum)(wasvoid stageParamChange(), which has no valid mangled name). The asm returns 0/1 and passes the argument through to the virtual call, and passingm_scene_numis what completesupdateScene.gmMeleeInitData::m_gameModeis au8bitfield instead ofGameMode.m_playeMode/m_eventIdare in a union withu8 m_eventFlagsat 0x08 in the matching build only; the portable build keeps the two named bitfields.stEmblem::unk744is renamedm_lampEffectIndex.create__8stEmblemFvis kept withforce_active, same as st_crayon.