Repository navigation
Match em_manager.cpp and em_archive.cpp - #170
Open
loserkidsblink wants to merge 1 commit into
Open
loserkidsblink wants to merge 1 commit into
loserkidsblink wants to merge 1 commit into
Conversation
Report for RSBE01_02 (7074404 - ee0632c)📈 Matched code: 1.76% (+0.03%, +5340 bytes) ✅ 42 new matches
...and 12 more new matches |
loserkidsblink
force-pushed
the
port/em-archive
branch
4 times, most recently
from
November 8, 2026 03:05
37f4c88 to
d7deef1
Compare
Port of the old local em-manager/em-archive drafts onto current main, with their header dependencies (previously in BrawlHeaders) moved into include/Brawl/Include. sndSystem's 0x80073D08 is what emManager actually calls (verified against the original REL relocation); upstream names 0x80073D18 isSoundGroupLoaded, so D08 keeps an address-based name for now.
loserkidsblink
force-pushed
the
port/em-archive
branch
from
November 8, 2026 12:51
d7deef1 to
ee0632c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header changes that affect BrawlHeaders users:
emManager::Entryis no longer a template; one class with avoid*data pointer is shared by the enemy and archive tables.emManagerid/index params are nowu32.emManager/emArchivegetters,emManager::isParentandEnemy::getEnemyKindare nowconst.preloadArchivekeeps its customHeapTypeparameter in the non-matching declaration; the body allocates fromHeaps::EnemyInstancelike the game does.sndSystem::fn_80073D08is nowisSoundGroupLoadFinished(const).utArchiveManager::isLoadedis nowint isLoaded(u32 id, u32* p2) const.