LEGO: Pull request from juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260905103229221 to main - #12691
Open
csigs wants to merge 1 commit into
Open
Conversation
csigs
requested review from
jonathanpeppers and
simonrozsival
as code owners
September 5, 2026 10:32
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Czech XA1049 translation change alters the original meaning, and the Turkish/Japanese additions risk mixed-language error output due to missing <Tgt> entries.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates localization .resx.lcl files for Xamarin.Android.Build.Tasks to include new resource entries for error codes XA4325 and XA4326, and adjusts an existing Czech translation.
Changes:
- Add new localized string entries for
XA4325,XA4325_AssemblyFailure,XA4325_SourceDestinationCount, andXA4326across multiple locales. - Update the Czech localization text for the
AndroidEnableMarshalMethods/PublishReadyToRunmessage.
File summaries
| File | Description |
|---|---|
| Localize/loc/zh-Hant/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds zh-Hant localized entries for XA4325/XA4326. |
| Localize/loc/zh-Hans/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds zh-Hans localized entries for XA4325/XA4326. |
| Localize/loc/tr/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds XA4325/XA4326 entries; some new entries are missing <Tgt> translations. |
| Localize/loc/ru/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds Russian localized entries for XA4325/XA4326. |
| Localize/loc/pt-BR/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds pt-BR localized entries for XA4325/XA4326. |
| Localize/loc/pl/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds Polish localized entries for XA4325/XA4326. |
| Localize/loc/ko/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds Korean localized entries for XA4325/XA4326. |
| Localize/loc/ja/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds XA4325/XA4326 entries; some new entries are missing <Tgt> translations. |
| Localize/loc/it/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds Italian localized entries for XA4325/XA4326. |
| Localize/loc/fr/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds French localized entries for XA4325/XA4326. |
| Localize/loc/es/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds Spanish localized entries for XA4325/XA4326. |
| Localize/loc/de/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds German localized entries for XA4325/XA4326. |
| Localize/loc/cs/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds Czech localized entries for XA4325/XA4326 and modifies an existing Czech message translation. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 3
- Review effort level: Lite
Comment on lines
967
to
971
| <Str Cat="Text"> | ||
| <Val><![CDATA[The 'AndroidEnableMarshalMethods' and 'PublishReadyToRun' MSBuild properties cannot both be set to 'true'. Set one property to 'false'.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Vlastnosti MSBuildu AndroidEnableMarshalMethods a PublishReadyToRun nelze současně nastavit na hodnotu true. Nastavte jednu vlastnost na false.]]></Val> | ||
| <Val><![CDATA[Vlastnosti MSBuildu AndroidEnableMarshalMethods a PublishReadyToRun nelze nastavit na hodnotu true. Nastavte jednu vlastnost na false.]]></Val> | ||
| </Tgt> |
Comment on lines
+1920
to
+1924
| <Item ItemId=";XA4325_AssemblyFailure" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true"> | ||
| <Str Cat="Text"> | ||
| <Val><![CDATA[Could not rewrite the JNI names in the assembly '{0}': {1}]]></Val> | ||
| </Str> | ||
| <Disp Icon="Str" /> |
Comment on lines
+1920
to
+1924
| <Item ItemId=";XA4325_AssemblyFailure" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true"> | ||
| <Str Cat="Text"> | ||
| <Val><![CDATA[Could not rewrite the JNI names in the assembly '{0}': {1}]]></Val> | ||
| </Str> | ||
| <Disp Icon="Str" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260905103229221 to main with localized lcls