Repository navigation
Re-enable .NET 12 framework assembly checks - #69974
Merged
wtgodbe merged 3 commits intoOct 23, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
area-blazor
Contributor
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Human review should confirm Windows/Linux CI and the generated package dependency graph, which were not independently validated here.
No open issues 🎉
What changed in this PR
Completes the .NET 12 rollover follow-up by restoring framework identity checks and aligning Components.AI with the in-tree Components.Web build.
Changes:
- Re-enables three framework tests without changing their assertions.
- Replaces Components.AI’s ASP.NET Core 11 Web package reference with an in-tree project reference, retaining Web as a package dependency when packed.
- Removes the unused central Components.Web package version pin.
| File | Description |
|---|---|
| src/Framework/test/TargetingPackTests.cs | Restores assembly-version and reference-assembly checks. |
| src/Framework/test/SharedFxTests.cs | Restores shared-framework assembly-version checks. |
| src/Components/AI/src/Microsoft.AspNetCore.Components.AI.csproj | References the in-tree Components.Web project. |
| Directory.Packages.props | Removes the obsolete Components.Web 11 package pin. |
Review effort: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe
changed the title
wtgodbe
temporarily deployed
to
copilot-pat-pool
October 23, 2026 05:01 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
wtgodbe
temporarily deployed
to
copilot-pat-pool
October 23, 2026 05:01 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
wtgodbe
temporarily deployed
to
copilot-pat-pool
October 23, 2026 05:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
wtgodbe
temporarily deployed
to
copilot-pat-pool
October 23, 2026 05:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
wtgodbe
temporarily deployed
to
copilot-pat-pool
October 23, 2026 05:05 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
wtgodbe
temporarily deployed
to
copilot-pat-pool
October 23, 2026 05:06 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
✅ No documentation PR was created. Confidence that documentation is needed: 2% No docs needed: the PR only re-enables internal framework assembly tests. Documentation surfaces considered
|
wtgodbe
temporarily deployed
to
copilot-pat-pool
October 23, 2026 05:06 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This was referenced Oct 31, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore framework identity checks after the .NET 12 dependency rollover.
Description
The temporary bootstrap assembly-version pin was already removed in #69836. This PR re-enables the three framework tests without weakening their assertions:
SharedFxTests.SharedFrameworkAssembliesHaveExpectedAssemblyVersionsTargetingPackTests.RefAssembliesHaveExpectedAssemblyVersionsTargetingPackTests.AssembliesAreReferenceAssembliesComponents.AI retains its existing ASP.NET Core 11 Web package dependency. Its dependency migration is intentionally excluded from this PR.
Validation
Validated locally on macOS arm64 with the repository-pinned .NET 12 SDK and
DotNetUseShippingVersions=true:Microsoft.AspNetCore.App.RefNuGet package haveReferenceAssemblyAttributeand assembly version12.0.0.0: System.Security.Cryptography.Xml, System.Security.Cryptography.Pkcs, System.Formats.Cbor, System.Diagnostics.EventLog, and System.Threading.RateLimiting.Windows and Linux validation is left to CI.
Related to #69595.