You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Cleanup unused parameter from /PasskeyRequestOptions - #70387
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The passkey login test still expects a username query parameter, so its request predicate will not match the new query-free URL and the test will time out unless updated.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The passkey test still expects a username query parameter on a request that now has no query string, causing the assertion to fail even when sign-in succeeds.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Update URL assertion for queryless passkey request
The updated client sends /Account/PasskeyRequestOptions without a query string, but line 609 still asserts that the captured URL contains username=.... Once this predicate captures the new request, that assertion fails even when passkey sign-in succeeds. Replace it with an assertion that the query string is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area-commandlinetoolsIncludes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.