Repository navigation
Conversation
makazeu
marked this pull request as ready for review
October 12, 2026 08:19
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
1 similar comment
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
MihaZupan
reviewed
Oct 12, 2026
This was referenced Oct 12, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> # Conflicts: # src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Uri.EqualsandUri.GetHashCodeuse a cached representation based onUriComponents.HttpRequestUrl, which omits IPv6 scope IDs. Consequently, URIs such ashttp://[fe80::1%1]/andhttp://[fe80::1%2]/can compare equal despite identifying different local network zones.This affects consumers that use
Urias a key. InSocketsHttpHandler, changing a proxy's IPv6 scope can reuse the previous proxy's connection pool and select the wrong connection endpoint. This change fixes URI identity at the source rather than introducing a handler-specific workaround.Approach
%0, without resolving interface names or normalizing scope values.HttpRequestUrlwithout initializing the host or scope cache; including that lazy cache could change a URI's hash after accessing host properties.HttpRequestUrlcontinues to omit scope IDs. Scope identifies a local network zone and is needed for connection selection, but should not be transmitted as part of an outgoing HTTP URI. The fix separates local URI identity from that request representation.Testing
Validated in Ubuntu 24.04 ARM64 Docker:
./build.sh clr+libs -rc Releaseand the updated URI library build passed.Resolves #135103
Note
This description was generated with GitHub Copilot.