Skip to content

Fix NativeAOT tool package paths for extensionless executables - #136755

Merged
jkoritzinsky merged 1 commit into
dotnet:mainfrom
am11:fix-nativeaot-tool-package-path
Oct 31, 2026
Merged

jkoritzinsky merged 1 commit into
dotnet:mainfrom
am11:fix-nativeaot-tool-package-path

Conversation

@am11

@am11 am11 commented Oct 31, 2026

Copy link
Copy Markdown
Member

Split from #123848 per #123848 (comment).

NuGet treats a PackagePath that doesn't end with the file's extension as a folder. On Unix the NativeAOT tool executable has no extension, so the managed ilasm package currently has it at runtimes/<rid>/native/ilasm/ilasm instead of runtimes/<rid>/native/ilasm, where Microsoft.NET.Sdk.IL looks for it. Windows is unaffected (ilasm.exe).

The fix passes the containing folder as the content PackagePath; the symbol package paths are unchanged. Also adds eng/NativeAotToolPackage.targets to the ilasm pipeline triggers.

Verified locally on linux-x64 with ./build.sh -s tools.ilasm -pack:

runtime.linux-x64.Microsoft.NETCore.ILAsm.nupkg          runtimes/linux-x64/native/ilasm
runtime.linux-x64.Microsoft.NETCore.ILAsm.symbols.nupkg  runtimes/linux-x64/native/{ilasm,ilasm.dbg,ILAssembler.pdb}

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Oct 31, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 6 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

@am11
am11 requested a review from jkoritzinsky October 31, 2026 16:45
@jkoritzinsky
jkoritzinsky enabled auto-merge (squash) October 31, 2026 17:45
@jkoritzinsky

Copy link
Copy Markdown
Member

/ba-g time zone test failure unrelated

@jkoritzinsky
jkoritzinsky merged commit 0847653 into dotnet:main Oct 31, 2026
219 of 230 checks passed
@am11
am11 deleted the fix-nativeaot-tool-package-path branch October 31, 2026 22:04
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants