Repository navigation
Fix NativeAOT tool package paths for extensionless executables - #136755
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 6 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
jkoritzinsky
approved these changes
Oct 31, 2026
jkoritzinsky
enabled auto-merge (squash)
October 31, 2026 17:45
Member
|
/ba-g time zone test failure unrelated |
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #123848 per #123848 (comment).
NuGet treats a
PackagePaththat doesn't end with the file's extension as a folder. On Unix the NativeAOT tool executable has no extension, so the managed ilasm package currently has it atruntimes/<rid>/native/ilasm/ilasminstead ofruntimes/<rid>/native/ilasm, whereMicrosoft.NET.Sdk.ILlooks for it. Windows is unaffected (ilasm.exe).The fix passes the containing folder as the content
PackagePath; the symbol package paths are unchanged. Also addseng/NativeAotToolPackage.targetsto the ilasm pipeline triggers.Verified locally on linux-x64 with
./build.sh -s tools.ilasm -pack: