Repository navigation
Deduplicate container processing - #1101
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the shared container-processing lifecycle refactor.
No open issues 🎉
What changed in this PR
Refactors AggregatingSigner to share the container-processing lifecycle while preserving ZIP/NuGet, APPX, and APPX bundle policies.
Changes:
- Extracts opening, file enumeration, recursive signing, saving, and disposal into
ProcessContainersAsync. - Keeps format-specific file selection and save behavior, including saving APPX containers when no matching files are found.
| File | Description |
|---|---|
| src/Sign.Core/DataFormatSigners/AggregatingSigner.cs | Replaces duplicated container-processing flows with a shared helper. |
Review effort: Balanced
jeffkl
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
dotnet test test\Sign.Core.Test\Sign.Core.Test.csproj685 tests passed.