Skip to content

fix: handle malformed SAMLResponse on saml auth and logout endpoints - #737

Merged
b0ink merged 1 commit into
doubtfire-lms:11.1.xfrom
b0ink:fix/saml-malformed-response-handling
Oct 27, 2026
Merged

b0ink merged 1 commit into
doubtfire-lms:11.1.xfrom
b0ink:fix/saml-malformed-response-handling

Conversation

@b0ink

@b0ink b0ink commented Oct 27, 2026

Copy link
Copy Markdown
Member

No description provided.

- rescue errors raised while parsing the SAML response on /auth/jwt and return 401
- use Logoutresponse#validate instead of nonexistent is_valid? on /auth/saml_logout
- define host before redirecting on /auth/saml_logout
@sonarqubecloud

Copy link
Copy Markdown

@b0ink
b0ink merged commit 2530fdd into doubtfire-lms:11.1.x Oct 27, 2026
3 checks passed
b0ink added a commit that referenced this pull request Oct 27, 2026
…737)

- rescue errors raised while parsing the SAML response on /auth/jwt and return 401
- use Logoutresponse#validate instead of nonexistent is_valid? on /auth/saml_logout
- define host before redirecting on /auth/saml_logout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant