Remove 'name' attribute from tokenizer elements - #312
Open
beertje44 wants to merge 1 commit into
Open
Conversation
both name and class cause a startup error in current solr, it should be only one of those, so only class is retained.
|
Confirmed this works on Solr 9.10, but keeping name might be better according to the docs (it's not legacy) - what do you think? ref. https://solr.apache.org/guide/solr/9_10/indexing-guide/tokenizers.html |
Author
|
Previous edit added class, so that is why I kept that one: |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
both name and class cause a startup error in current solr, it should be only one of those, so only class is retained.
Pull Request
If this pull request fixes, discloses, demonstrates or discusses a suspected security vulnerability,
DO NOT submit it publicly. Follow SECURITY.md and report it privately.
AI policy
Dovecot allows AI assisted or generated code, but we would like to know if it is such.
Do not include 'Co-Authored-By' header in the commit.
Type of Change
Description
Both solr 9.8+ and current 10 versions refuse to load core schema when tokenizer has both name and class properties. Only keeping class here seemed like the right thing to do. After this my dovecot core loads and works withwith solr-10.0.0 on my system.
Additional Notes