lib: xxh64: fix byte ordering bug on big-endian systems - #314
Open
nmeyerhans wants to merge 1 commit into
Open
Conversation
Convert from little-endian to host byte order where necessary. Background at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1146449
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert from little-endian to host byte order where necessary.
Background at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1146449
Pull Request
AI policy
Dovecot allows AI assisted or generated code, but we would like to know if it is such.
Do not include 'Co-Authored-By' header in the commit.
Type of Change
Description
When dovecot reads multi-byte data from memory and interprets it as unsigned integer data, it fails to properly convert from little endian (as required in the xxh64 spec) to host byte order. This results in different has values depending on the host byte order.
This was identified by the test suite when building Dovecot for Debian/s390x. See the Debian bug and build log for more.