Repository navigation
Run model: a live run's duration is now minus its start - #342
Merged
Merged
Conversation
The host's durationMs for a live run moves in jumps (22a read 53h 26m from 04:37Z to 05:43Z, and at 05:58Z still ended at 05:53:39Z), so the header's 'running' time and 'Where the time went' froze while the chart ran on. The workspace polls every 15 s while live, so the model recomputes from the clock.
drewstone
added a commit
that referenced
this pull request
Oct 27, 2026
…tick (#341-#344) (#345) 0.90.41: run files phone frame, live duration, Check card, last hour tick Ships merged #341, #342, #343 and #344: the run Files pane keeps its 80dvh frame on a phone, a live run's duration is now minus its start, the Check card points to the latest line in Checks instead of printing it, and the strip's last hour tick sits a whole step before the end clock. package.json +1 -1. Run ID: run_c9c3fa4d167d8e14a2fd554bc4730081
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 29 truth fault (disco-ui-review 05:56Z): 22a's header read '53h 26m running' from 04:37Z on, and the Overview's 'Where the 53h 26m went' used the same figure, while the chart and Latest step read 54h 47m.
Cause:
buildModelprefers the host'srun.durationMs, which for a live run moves in jumps. Three reads at 05:57, 05:58 and 05:58Z all ended at 05:53:39Z, and at 05:43 it ended at 04:26Z. The run document isn't polled, but the workspace is, every 15 s while live.Change: a live run's duration is now minus its start; a settled run keeps the host's figure. model.ts +1 -1.
Run ID: run_cb0acd68ebd3ffe593924ee346ed8c3c