Repository navigation
Run overview: the last hour tick sits a whole step before the end clock - #344
Merged
Merged
Conversation
At the judges' 1400 px viewport 22a's axis still read '49h04:26': an 8% margin is width-dependent. A tick now shows only when the next one would also fit, so the end clock always has a tick spacing (about 1/8 of the strip) to itself.
drewstone
added a commit
that referenced
this pull request
Oct 27, 2026
…tick (#341-#344) (#345) 0.90.41: run files phone frame, live duration, Check card, last hour tick Ships merged #341, #342, #343 and #344: the run Files pane keeps its 80dvh frame on a phone, a live run's duration is now minus its start, the Check card points to the latest line in Checks instead of printing it, and the strip's last hour tick sits a whole step before the end clock. package.json +1 -1. Run ID: run_c9c3fa4d167d8e14a2fd554bc4730081
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disco-ui-review 06:04Z (4x crops at the judges' 1400x876 viewport): 22a's Whole run axis still reads '49h04:26' in both themes. My #339 margin (the last 8% of the strip) only clears at 1512 px.
Now a tick shows only when the next tick would also fit before the end. The end clock always gets one tick spacing (about 1/8 of the strip): 21c's last tick is 18h (24% before the end), 22a's is 42h (23%). Overview.tsx +1 -1.
Run ID: run_cb0acd68ebd3ffe593924ee346ed8c3c