Skip to content

fix: agents hold PRs with draft or human:review and never arm auto-merge #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobpevans-release-please merged 1 commit into from
Oct 25, 2026
Merged

fix: agents hold PRs with draft or human:review and never arm auto-merge #657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions github-workflows/skills/ship/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,13 @@ git status --porcelain
`npm run lint`, `make lint`, etc.). If failures are found, fix them and amend the commit.
Skip this step if no lint command is discoverable.
6. Push: `git push -u origin HEAD`
7. Create PR: `gh pr create --fill` (or with title/body derived from commit).
Never pass `--draft`. Include the session id (`<runtime>-<host>-<8hex>`) in
the PR body. Unless the PR needs `human:review` or is a promotion into a
production branch, enable auto-merge: `gh pr merge <PR_NUMBER> --auto --squash`.
An open PR does not merge by itself without it — never assume it merged.
7. Create a PR: `gh pr create --fill` (or with title/body derived from the commit).
Use a draft or add `human:review` if it must wait for a person. Include the
session id (`<runtime>-<host>-<8hex>`) in the PR body. The org `pr-automerge`
workflow arms non-draft PRs without `human:review`; agents never arm auto-merge.
It uses a merge commit for PRs into `main` on git-flow repos and squash otherwise.
It never arms `develop` to `main` promotions. Never assume the PR merged;
verify its state before reporting.
8. **Pacing**: Run `sleep 2` after `gh pr create` to allow GitHub to index the PR
9. Capture PR number from output (look for `pull/NUMBER` pattern)
10. Add it to the PR list
Expand Down
Loading