Repository navigation
Skip placement groups for AWS Capacity Blocks - #4345
Merged
Merged
Conversation
AWS rejects launches into Capacity Blocks that specify a placement group. Fixes #4344.
AWS omits ReservationType for regular capacity reservations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4344
Fixes #4346
Compute.are_placement_groups_compatible_with_reservations(backend_type)is replaced byare_placement_groups_compatible_with_reservation(instance_offer, reservation)so that backends can decide per reservation, and both provisioning paths now call it viarun_asyncbecause the AWS implementation makes an API call.get_reservation()gets anactive_onlyflag so a Capacity Block is recognized before it starts, and no longer fails when AWS omitsReservationType, as it does for regular capacity reservations.reservationnow launch into that reservation even if the run doesn't setreservationitself, since the defaultrun_job()and the placement group check now use the effective requirements instead of the job spec.