Skip to content

fix: reject unavailable frames and pace health checks - #11

Merged
hoangsvit merged 4 commits into
mainfrom
fix/camera-health-placeholder-pacing
Oct 6, 2026
Merged

hoangsvit merged 4 commits into
mainfrom
fix/camera-health-placeholder-pacing

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

Summary

Corrects the scheduled camera health checker already on main.

Fixes

  • detect the upstream static IMAGE NOT AVAILABLE payload as unavailable even though the proxy returns HTTP 200 + image/jpeg
  • detection uses the actual PNG signature and stable 290x183 dimensions observed from live probes
  • reduce health-check concurrency from 12 to 2
  • add 250ms pacing between checks per worker
  • increase workflow timeout to 20 minutes to allow safer low-rate scanning

Why

A concurrency-12 run caused the upstream to return the unavailable placeholder for 634/797 cameras, which polluted Online/Offline totals. Lowering request pressure prevents the checker from creating the failure condition it is trying to measure.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 337178a6-b6ea-4539-8e63-c05b837f0bff
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hoangsvit
hoangsvit merged commit ae6413b into main Oct 6, 2026
2 checks passed
@hoangsvit
hoangsvit deleted the fix/camera-health-placeholder-pacing branch October 6, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant