Skip to content

feat: structure camera addresses and enrich legacy districts with VietMap - #13

Merged
hoangsvit merged 8 commits into
mainfrom
feature/vietmap-legacy-addresses
Oct 7, 2026
Merged

hoangsvit merged 8 commits into
mainfrom
feature/vietmap-legacy-addresses

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

Summary

  • migrate camera data to a structured Address.legacy/current schema
  • filter UI strictly by legacy district/county level
  • use VietMap v4 display_type=6 to persist old-format address plus the new-format equivalent
  • persist full address components and coordinates from Place v4
  • add scheduled/manual enrichment workflow using VIETMAP_API_KEY
  • validate the structured schema in CI

Data flow

CamName + legacy district + HCMC → VietMap Geocode v4 → fallback Autocomplete v4 → Place v4 → Location + Address.legacy + Address.current.

The public UI reads only the cached JSON and never calls VietMap at page-load time.

Note

The repository secret VIETMAP_API_KEY is required for the enrichment workflow. Existing legacy district values are preserved during the schema migration, so filtering works before the first enrichment run.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ec4824c8-8c07-4561-aa0d-a063efd44970
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hoangsvit
hoangsvit merged commit 7ce2839 into main Oct 7, 2026
2 checks passed
@hoangsvit
hoangsvit deleted the feature/vietmap-legacy-addresses branch October 7, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant